Output gradients in export_testcase #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed that the name of gradient files should be consistent with the names in .onnx file, which is based on |
|
After #118 is merged, |
shinh
approved these changes
Mar 1, 2019
|
LGTM, but how about adding a simple test? |
|
Sure, I'll try to write a simple test. |
|
Added some test for |
disktnk
reviewed
Mar 1, 2019
|
|
||
| def test_export_testcase(self): | ||
| # Just check the existence of pb files | ||
| path = 'out/test_export_testcase' |
There was a problem hiding this comment.
This code works on Windows, but it's better to use os.path.join and "out" is got from onnx_chainer.testing.test_onnxruntime.TEST_OUT_DIR. However related to this directory will be fixed in #117 and next PR , so it's fine like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented new option in
export_testcaseto output gradients as well. This may be useful for the development of chainer-compiler.