feat: add block api wiring and block api proxy server for standalone mode #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
damiannolan
requested review from
rootulp,
chatton,
cmwaters,
julienrbrt,
evan-forbes and
ninabarbakadze
19 tasks
yes |
chatton
approved these changes
Apr 14, 2025
rootulp
approved these changes
Apr 14, 2025
rootulp
pushed a commit
to celestiaorg/celestia-app
that referenced
this pull request
May 7, 2025
## Overview Due to the multiplexer copying start command functionality from the sdk, I discovered that running native apps (for example, v4) will not expose the core BlockAPI when through the multiplexer, i.e. the changes in celestiaorg/cosmos-sdk#455 do not take effect which spin up the core BlockAPI in-process. The BlockAPI is however available right now when: - Running embedded apps (for example, v3) through the multiplexer. - Running a v4 standalone app without the multiplexer. The replication of start command code being distributed and copied amongst different places is extremely error prone to manage, and quite frankly, its spaghetti. --------- Co-authored-by: chatton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Wires the block api for in-process and out-of-process tendermint nodes.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change