fix: ensure core block api runs through multilplexer native app #4767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damiannolan
requested review from
cmwaters and
rach-id
and removed request for
a team
|
Can you update the multiplexer.Dockerfile to depend on EDIT: just did it myself hope you don't mind :D |
chatton
approved these changes
May 7, 2025
evan-forbes
approved these changes
May 7, 2025
rootulp
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Due to the multiplexer copying start command functionality from the sdk, I discovered that running native apps (for example, v4) will not expose the core BlockAPI when through the multiplexer, i.e. the changes in celestiaorg/cosmos-sdk#455 do not take effect which spin up the core BlockAPI in-process.
The BlockAPI is however available right now when:
The replication of start command code being distributed and copied amongst different places is extremely error prone to manage, and quite frankly, its spaghetti.