-
Notifications
You must be signed in to change notification settings - Fork 1k
deps: Bump SDK to version 0.50 and Celestia App to V4 #4219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: modify go.mod, fix low hanging fruit api breakages
…f app grpc in tests
2 tasks
renaynay
reviewed
Apr 23, 2025
renaynay
reviewed
Apr 25, 2025
renaynay
approved these changes
Apr 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all fine w me, we will FLUP w app team later re: thing we discussed in sync.
Are ya'll waiting to merge this until after Slava + Sysrex's manual testing of celestia-node <> celestia-app compatibility? |
walldiss
approved these changes
May 8, 2025
walldiss
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR bumps celestia-app to use v4 and the sdk to be on v0.50
Marking as R4R but shouldn't be merged unless we are happy to do a follow up to update celestia-app to a final release tag.
The only failing integration test is one that looks like it is already failing on main.
NOTE: this PR is still pinning celestia-app to an in-development build from this PR celestiaorg/celestia-app#4580 so nothing should be merged until there is a tag that includes this fix. This is required for the test code to correctly start theBlockApi