feat: enable block api and block api proxy service (standalone) #4580

damiannolan · 2025-04-15T11:42:44Z

Overview

Updates dependencies to enable core block api (in-process) and block api proxy service (standalone).

go.mod

damiannolan · 2025-04-15T11:46:33Z

Do you want a default address/port set for the core grpc server in app/default_overrides?
Note, this is only required when running the app in standalone mode (multiplexer). The multiplexer will error on startup if this config is not set

diff --git a/app/default_overrides.go b/app/default_overrides.go
index e187647e..32167a5b 100644
--- a/app/default_overrides.go
+++ b/app/default_overrides.go
@@ -257,6 +257,7 @@ func DefaultConsensusConfig() *tmcfg.Config {
        // Set broadcast timeout to be 50 seconds in order to avoid timeouts for long block times
        cfg.RPC.TimeoutBroadcastTxCommit = 50 * time.Second
        cfg.RPC.MaxBodyBytes = int64(8388608) // 8 MiB
+       cfg.RPC.GRPCListenAddress = "tcp://0.0.0.0:9099"
 
        cfg.Mempool.TTLNumBlocks = 12
        cfg.Mempool.TTLDuration = 75 * time.Second

coderabbitai · 2025-04-15T11:48:41Z

📝 Walkthrough

Walkthrough

The changes remove several dependencies from the go.mod file, including github.com/tendermint/tendermint as a direct dependency and some indirect dependencies, while reintroducing github.com/tendermint/tendermint as an indirect dependency with the same zero version. The replacement versions for github.com/cometbft/cometbft and github.com/cosmos/cosmos-sdk are updated to newer release candidates. In the test utilities, the Tendermint node is now explicitly configured for RPC before starting the gRPC server, passing the resulting core environment to the server startup. The StartGRPCServer function signature is updated accordingly, registering a new block API and launching a block event listener goroutine. Additionally, the random assignment of a gRPC listen port in the Tendermint config is removed, and commission rate initialization in genesis account code is simplified.

Changes

File(s)	Change Summary
go.mod	Removed several dependencies from `require`; reintroduced `tendermint` as indirect; updated `cometbft` and `cosmos-sdk` replacement versions.
test/util/testnode/network.go	Added explicit call to `tmNode.ConfigureRPC()` before starting gRPC server; passed resulting `coreEnv` to `StartGRPCServer`.
test/util/testnode/rpc_client.go	Updated `StartGRPCServer` signature to accept `coreEnv`; registered new `BlockAPI` to gRPC server; launched block event listener goroutine.
test/util/testnode/config.go	Removed assignment of a random open port to `tmCfg.RPC.GRPCListenAddress` in `DefaultTendermintConfig`; field now left unset or default.
test/util/genesis/accounts.go	Simplified commission rate initialization by replacing string parsing with direct decimal construction in `Validator.GenTx` method.

Sequence Diagram(s)

sequenceDiagram
    participant TestNode as Tendermint Node
    participant GRPCServer as gRPC Server
    participant BlockAPI as BlockAPI

    TestNode->>TestNode: ConfigureRPC()
    Note right of TestNode: Returns coreEnv

    TestNode->>GRPCServer: StartGRPCServer(coreEnv)
    GRPCServer->>BlockAPI: Register BlockAPI(coreEnv)
    GRPCServer->>BlockAPI: Start block event listener (goroutine)
    GRPCServer->>GRPCServer: Start gRPC server (blocking)

Suggested reviewers

cmwaters
rootulp
ninabarbakadze

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (1.64.8)

Error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2
Failed executing command with error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ff60459 and 5138040.

📒 Files selected for processing (1)

test/util/genesis/accounts.go (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (8)

GitHub Check: lint / golangci-lint
GitHub Check: test / test-coverage
GitHub Check: test / test-race
GitHub Check: test / test
GitHub Check: markdown-linter / markdown-link-check
GitHub Check: test / test-short
GitHub Check: test / test-fuzz
GitHub Check: Summary

🔇 Additional comments (1)

test/util/genesis/accounts.go (1)

117-117:
✅ Verification successful

Verify commission rate value change

The commission rate has been changed from what appears to be 0.5 (50%) in the previous implementation to 0.05 (5%) with math.LegacyNewDecWithPrec(5, 2). While this simplifies the code by removing string parsing and error handling, please confirm this is an intentional change in test validator commission rates.

The new implementation is more direct and less error-prone since it avoids string parsing, but the rate value difference could potentially affect test outcomes.

🏁 Script executed:
#!/bin/bash
# Check if this commission rate is used consistently across the codebase
# and if other test validators use the same rate

# Find other instances of commission rate initialization
rg "NewCommissionRates" --type go
rg "LegacyNewDecWithPrec\(5, 2\)" --type go
Length of output: 653
Commission Rate Verified as 5%

The commission rate in test/util/genesis/accounts.go now uses math.LegacyNewDecWithPrec(5, 2), which correctly computes to 0.05 (5%). This is corroborated by its consistent use in app/default_overrides.go (where it’s commented as 5%) and appears to be an intentional refactor to avoid string parsing. Note that different test files (e.g., app/test/std_sdk_test.go) use other values for their specific scenarios, which seems deliberate.

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

damiannolan · 2025-04-15T12:07:38Z

Looks like there is tests failing all of a sudden. Going to look into it.

edit; fixed

cmwaters · 2025-04-15T12:49:37Z

Looks like the tests are still failing

damiannolan · 2025-04-15T13:31:34Z

Looks like the tests are still failing

yeah, they passed in a3e6352 but adding a stop to the blockAPI listener seems to have exploded things. Working on getting this resolved asap

damiannolan · 2025-04-15T15:01:42Z

💀 picking up new tag with commission changes causing other test failures...

feat: enable block api and block api proxy service (standalone)

6705c26

github-actions bot added the external label Apr 15, 2025

damiannolan commented Apr 15, 2025

View reviewed changes

go.mod Outdated Show resolved Hide resolved

damiannolan marked this pull request as ready for review April 15, 2025 11:46

damiannolan requested a review from a team as a code owner April 15, 2025 11:46

damiannolan requested review from cmwaters and evan-forbes and removed request for a team April 15, 2025 11:46

chore: enable block api in test utils

3cf4a58

celestia-bot requested review from ninabarbakadze, rach-id and rootulp April 15, 2025 12:00

evan-forbes previously approved these changes Apr 15, 2025

View reviewed changes

evan-forbes added this to core/app Apr 15, 2025

github-project-automation bot moved this to Needs Triage in core/app Apr 15, 2025

evan-forbes added the WS: V4 label Apr 15, 2025

chore: run the block event listener in a separate go routine

a3e6352

damiannolan dismissed evan-forbes’s stale review via a3e6352 April 15, 2025 12:20

celestia-bot requested a review from evan-forbes April 15, 2025 12:21

evan-forbes moved this from Needs Triage to Done in core/app Apr 15, 2025

evan-forbes moved this from Done to In Review in core/app Apr 15, 2025

chore: stop the block api in cleanup func

521cc60

rootulp assigned damiannolan Apr 15, 2025

damiannolan added 2 commits April 15, 2025 16:28

chore: ignore err when restarting block api service

9cd1ae2

chore: add nolint to errcheck for block api listener

51501d0

damiannolan added 2 commits April 15, 2025 16:46

chore: use rc1 of celestiaorg/cosmos-sdk

e0fbe92

chore: nit go mod comment

ff60459

fix: commission rates on test util

5138040

evan-forbes approved these changes Apr 15, 2025

View reviewed changes

chatton mentioned this pull request Apr 16, 2025

deps: Bump SDK to version 0.50 and Celestia App to V4 celestiaorg/celestia-node#4219

Merged

rootulp approved these changes Apr 16, 2025

View reviewed changes

damiannolan merged commit 29388c8 into main Apr 16, 2025
29 checks passed

damiannolan deleted the damian/enable-block-api branch April 16, 2025 15:13

github-project-automation bot moved this from In Review to Done in core/app Apr 16, 2025

rootulp mentioned this pull request Apr 30, 2025

test: local test bridge node #4717

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: enable block api and block api proxy service (standalone) #4580

feat: enable block api and block api proxy service (standalone) #4580

Uh oh!

damiannolan commented Apr 15, 2025

Uh oh!

Uh oh!

damiannolan commented Apr 15, 2025

Uh oh!

coderabbitai bot commented Apr 15, 2025 •

edited

Loading

Walkthrough

Changes

Sequence Diagram(s)

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

damiannolan commented Apr 15, 2025 •

edited

Loading

Uh oh!

cmwaters commented Apr 15, 2025

Uh oh!

damiannolan commented Apr 15, 2025 •

edited

Loading

Uh oh!

damiannolan commented Apr 15, 2025

Uh oh!

Uh oh!

Uh oh!

feat: enable block api and block api proxy service (standalone) #4580

feat: enable block api and block api proxy service (standalone) #4580

Uh oh!

Conversation

damiannolan commented Apr 15, 2025

Overview

Uh oh!

Uh oh!

damiannolan commented Apr 15, 2025

Uh oh!

coderabbitai bot commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

Documentation and Community

Uh oh!

damiannolan commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmwaters commented Apr 15, 2025

Uh oh!

damiannolan commented Apr 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

damiannolan commented Apr 15, 2025

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot commented Apr 15, 2025 •

edited

Loading

damiannolan commented Apr 15, 2025 •

edited

Loading

damiannolan commented Apr 15, 2025 •

edited

Loading