Skip to content

35 define the jargons in the paper #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 16, 2025
Merged

35 define the jargons in the paper #43

merged 11 commits into from
Apr 16, 2025

Conversation

BrodiePearson
Copy link
Collaborator

This PR addresses Issue #35

@BrodiePearson BrodiePearson linked an issue Mar 19, 2025 that may be closed by this pull request
Define the jargons in the paper #35
Closed
cassidymwagner
cassidymwagner approved these changes Apr 16, 2025
View reviewed changes
Copy link
Owner

@cassidymwagner cassidymwagner left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good!

I had a couple of merge conflicts when handling other issues that I believe have been resolved, but @BrodiePearson could you skim the PDF one more time to make sure your changes are reflected accurately. I believe the changes are correct based on the commit history, but I would like to be sure before I merge this.

@BrodiePearson
Copy link
Collaborator Author

BrodiePearson commented Apr 16, 2025 •
edited
Loading

Everything looks good!

I had a couple of merge conflicts when handling other issues that I believe have been resolved, but @BrodiePearson could you skim the PDF one more time to make sure your changes are reflected accurately. I believe the changes are correct based on the commit history, but I would like to be sure before I merge this.

It looks good to me! I just also updated the title and status for our paper that is under revision.

@cassidymwagner cassidymwagner merged commit b27fd1a into main Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cassidymwagner cassidymwagner cassidymwagner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define the jargons in the paper
2 participants
@BrodiePearson @cassidymwagner