Skip to content

Define the jargons in the paper #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaceKuailv opened this issue Mar 4, 2025 · 1 comment · Fixed by #43
Closed

Define the jargons in the paper #35

MaceKuailv opened this issue Mar 4, 2025 · 1 comment · Fixed by #43

Comments

@MaceKuailv
Copy link

There is a few jargons that are not explicitly defined in the paper. A few example include: ASF, SF_{LLL}, novel and blended SF.

For example, change
"...decomposition of longitudinal (along-r) and transverse (across-r) velocities, and data binning based on separation ..."
into
...decomposition of longitudinal (along-r, e.g. $SF_{LL},SF_{LLL}$) and transverse (across-r, e.g. $SF_{TT}$) velocities, and data binning based on separation ..."

I think staggered grid and curvilinear grid are worth mentioning in the paper or documentation. A quick search in the documentation also yields no results. Are they supported? It is totally fine if they are not supported. I am just being curious. Still, it is kind of important to let the readers know what kind of grids are supported.

P.S. It is a bit unlikely that I can get to the main software part this week. I'll try to make things move as fast as possible.

@MaceKuailv
Copy link
Author

This is part of the review for the joss paper openjournals/joss-reviews#7873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant