Skip to content

fix(useOverflowItems): fix useResizeObserver import #19560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025
Merged

fix(useOverflowItems): fix useResizeObserver import #19560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8d167a
chore(resize-observer): fix resize observer import
kennylam Jun 4, 2025
b65ac2d
chore(jest): update resize observer in overflow item test
kennylam Jun 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions packages/react/src/internal/__tests__/useOverflowItems-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@

import { renderHook, act } from '@testing-library/react';
import useOverflowItems from '../useOverflowItems';
import { useRef } from 'react';
import React from 'react';

// Mock ResizeObserver
const mockResizeObserver = jest.fn(() => ({
Expand All @@ -17,10 +15,9 @@ const mockResizeObserver = jest.fn(() => ({
disconnect: jest.fn(),
}));

// Mock use-resize-observer
jest.mock('use-resize-observer', () => ({
__esModule: true,
default: jest.fn(({ onResize }) => {
// Mock useResizeObserver
jest.mock('../../internal/useResizeObserver', () => ({
useResizeObserver: jest.fn(({ onResize }) => {
// Simulate resize behavior
if (onResize) {
setTimeout(() => onResize(), 0);
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/internal/useOverflowItems.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {
useRef,
useState,
} from 'react';
import useResizeObserver from 'use-resize-observer';
import { useResizeObserver } from './useResizeObserver';
import { usePreviousValue } from './usePreviousValue';

type Item = {
Expand Down
Loading