Skip to content

fix(useOverflowItems): fix useResizeObserver import #19560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kennylam
Copy link
Member

@kennylam kennylam commented Jun 4, 2025

Fixes resize observer import in useOverflowItems to use internal hook.

Changelog

Changed

  • use internal useResizeObserver rather than external package
  • update useResizeObserver tests

Testing / Reviewing

Everything should build and all CI flows should pass.

PR Checklist

As the author of this PR, before marking ready for review, confirm you:

  • Reviewed every line of the diff
  • Updated documentation and storybook examples
  • Wrote passing tests that cover this change
  • Addressed any impact on accessibility (a11y)
  • Tested for cross-browser consistency
  • Validated that this code is ready for review and status checks should pass

More details can be found in the pull request guide

@kennylam kennylam requested review from a team as code owners June 4, 2025 01:59
@kennylam kennylam requested a review from riddhybansal June 4, 2025 01:59
@kennylam kennylam added the package: react carbon-components-react label Jun 4, 2025
@kennylam kennylam requested a review from ariellalgilmore June 4, 2025 01:59
@kennylam kennylam changed the title fix(userOverflowItems): fix useResizeObserver import fix(useOverflowItems): fix useResizeObserver import Jun 4, 2025
Copy link

netlify bot commented Jun 4, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit b65ac2d
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-web-components/deploys/683fa881d56ccc0008465f31
😎 Deploy Preview https://deploy-preview-19560--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented Jun 4, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b65ac2d
🔍 Latest deploy log https://app.netlify.com/projects/v11-carbon-react/deploys/683fa881ff297d0008a5562e
😎 Deploy Preview https://deploy-preview-19560--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

codecov bot commented Jun 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.48%. Comparing base (a975063) to head (b65ac2d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19560   +/-   ##
=======================================
  Coverage   84.48%   84.48%           
=======================================
  Files         373      373           
  Lines       14735    14735           
  Branches     4838     4890   +52     
=======================================
  Hits        12449    12449           
+ Misses       2139     2138    -1     
- Partials      147      148    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@riddhybansal riddhybansal added this pull request to the merge queue Jun 4, 2025
Merged via the queue into carbon-design-system:main with commit 2d50233 Jun 4, 2025
37 checks passed
@kennylam kennylam deleted the fix/use-resize-observer-import branch June 4, 2025 12:26
@carbon-automation
Copy link
Contributor

Hey there! v11.84.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: react carbon-components-react
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants