fix(OverflowMenu): fix types #19158
Open
fix(OverflowMenu): fix types #19158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19158 +/- ##
==========================================
+ Coverage 84.87% 84.91% +0.04%
==========================================
Files 372 373 +1
Lines 14431 14504 +73
Branches 4748 4765 +17
==========================================
+ Hits 12248 12316 +68
- Misses 2037 2040 +3
- Partials 146 148 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fix OverflowMenuProps to include properties that get passed through to IconButton, for example align, autoAlign, and tooltip. Relatedly, fix TableToolbarMenuProps to extend OverflowMenuProps. I also removed the aria-label as it's redundant with iconDescription.
wkeese
force-pushed
the
fix-overflow-menu-props
branch
from
8588779 to
0d42224
Compare
PR carbon-design-system#19131 added align manually but I changed it to inherit from IconButtonProps (rather than repeating the definition).
wkeese
force-pushed
the
fix-overflow-menu-props
branch
from
9a54eed to
009cbd2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
OverflowMenuPropsto include properties that get passed through toIconButton, for examplealign,autoAlign, andtooltip.The alternative is to list the properties manually, which is what #19131 did for the
alignprop, but not for the other props.Relatedly, fix
TableToolbarMenuPropsto extendOverflowMenuProps. I also removed thearia-labelas it's redundant withiconDescription.Changelog
Changed
OverflowMenuandTableToolbar.Testing / Reviewing
Built carbon, and also built my app with the new carbon.