Skip to content

refactor: replace bounds logic with clamp and add tests #19118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

adamalston
Copy link
Contributor

Closes #19116

Replaced bounds logic with clamp and added tests.

Changelog

New

  • Added clamp tests.

Changed

  • Replaced bounds logic with clamp.

Testing / Reviewing

Reference commit: 6b4fe6f

yarn test packages/react

Copy link

netlify bot commented Apr 13, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit ccf62ce
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67fbc49c3502b300085d754f
😎 Deploy Preview https://deploy-preview-19118--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 13, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ccf62ce
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67fbc49c32403b0008b84fdf
😎 Deploy Preview https://deploy-preview-19118--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.25%. Comparing base (a6eb265) to head (ccf62ce).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19118   +/-   ##
=======================================
  Coverage   84.25%   84.25%           
=======================================
  Files         391      391           
  Lines       14552    14552           
  Branches     4740     4793   +53     
=======================================
  Hits        12261    12261           
  Misses       2131     2131           
  Partials      160      160           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@adamalston adamalston marked this pull request as ready for review April 13, 2025 14:42
@adamalston adamalston requested review from a team as code owners April 13, 2025 14:42
@adamalston
Copy link
Contributor Author

#19113 (comment)

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@alisonjoseph alisonjoseph added this pull request to the merge queue Apr 14, 2025
Merged via the queue into carbon-design-system:main with commit 7102995 Apr 14, 2025
53 of 54 checks passed
@adamalston adamalston deleted the 19116-clamp branch April 14, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace bounds logic with clamp
3 participants