-
Notifications
You must be signed in to change notification settings - Fork 1.9k
refactor: delete ReactAttr
#19113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: delete ReactAttr
#19113
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19113 +/- ##
=======================================
Coverage 84.57% 84.57%
=======================================
Files 381 381
Lines 14436 14436
Branches 4711 4763 +52
=======================================
Hits 12209 12209
+ Misses 2073 2072 -1
- Partials 154 155 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
I don't see a change in the diff in Percy. Not sure why it's failing. |
|
||
// TODO: When can this code be deleted? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code seems outdated — the comment says it was from June 2020, likely for V10 or earlier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It originated in #4820 which was targetted at a v10 issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems removable to me
|
||
// TODO: When can this code be deleted? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems removable to me
7283d7c
Hey there! v11.83.0 was just released that references this issue/PR. |
Closes #19111
Deleted
ReactAttr
.Changelog
Changed
Removed
ReactAttr
.Testing / Reviewing
Check for type errors in files.
I left a
TODO
with a question that hopefully someone can answer.