Skip to content

refactor: delete ReactAttr #19113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 20, 2025
Merged

Conversation

adamalston
Copy link
Contributor

Closes #19111

Deleted ReactAttr.

Changelog

Changed

  • Changed React namespace imports to default imports.

Removed

  • Deleted ReactAttr.

Testing / Reviewing

Check for type errors in files.

I left a TODO with a question that hopefully someone can answer.

Copy link

netlify bot commented Apr 12, 2025

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 049ea4d
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6818ef8bf8483a0008347905
😎 Deploy Preview https://deploy-preview-19113--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 12, 2025

Deploy Preview for v11-carbon-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 049ea4d
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6818ef8be628bf00085d3497
😎 Deploy Preview https://deploy-preview-19113--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Apr 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.57%. Comparing base (cd03c8a) to head (049ea4d).
Report is 55 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19113   +/-   ##
=======================================
  Coverage   84.57%   84.57%           
=======================================
  Files         381      381           
  Lines       14436    14436           
  Branches     4711     4763   +52     
=======================================
  Hits        12209    12209           
+ Misses       2073     2072    -1     
- Partials      154      155    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@adamalston adamalston marked this pull request as ready for review April 12, 2025 14:09
@adamalston adamalston requested review from a team as code owners April 12, 2025 14:09
@adamalston
Copy link
Contributor Author

I don't see a change in the diff in Percy. Not sure why it's failing.


// TODO: When can this code be deleted?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code seems outdated — the comment says it was from June 2020, likely for V10 or earlier.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It originated in #4820 which was targetted at a v10 issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems removable to me


// TODO: When can this code be deleted?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems removable to me

@tay1orjones tay1orjones added this pull request to the merge queue May 20, 2025
Merged via the queue into carbon-design-system:main with commit 7283d7c May 20, 2025
37 checks passed
@adamalston adamalston deleted the 19111-attr branch May 20, 2025 19:47
@carbon-automation
Copy link
Contributor

Hey there! v11.83.0 was just released that references this issue/PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete ReactAttr
5 participants