Skip to content

Update test plan and remove unneeded scenario #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

fernandopradocabrillo
Copy link
Collaborator

@fernandopradocabrillo fernandopradocabrillo commented Oct 30, 2024

What type of PR is this?

Add one of the following kinds:

  • bug
  • correction
  • tests

What this PR does / why we need it:

  1. Include a generic success scenario for when the idDocument is required
  2. Remove test for KNOW_YOUR_CUSTOMER.INVALID_TOKEN_CONTEXT since this code is no longer in the spec and it has been replace by generic INVALID_TOKEN_CONTEXT
  3. Various wording fixes

Which issue(s) this PR fixes:

Fixes #162

Special notes for reviewers:

This changes affect the test plan for v0.2.1. In my opinion, in order to have a full usable version we should merge it a do a release r1.4 before going for a v0.3 version.

Copy link
Collaborator

@GillesInnov35 GillesInnov35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Fernando

@fernandopradocabrillo fernandopradocabrillo merged commit 048ede2 into camaraproject:main Nov 7, 2024
1 check passed
@ToshiWakayama-KDDI
Copy link
Collaborator

Thanks Fernando.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test plan corrections for current version v0.2.1
3 participants