GH2685/2903: Integrate Cake.DotNetTool.Module #3207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In general, things are working - When using --tool-path, something isn't quite working right
- Change name of project to Cake.DotNetTool.Module - Switch to using tools folder by default - Can switch to using Global using pre-processor
…ule from MyGet for testing
…sting - Issue identified and corrected upstream in Cake.Recipe
So that Unit Test Code Coverage works
…led-sources' argument.
…ool version Previously, the Module wouldn't check to see what version of a Tool was installed. As a result, when a tool was already installed, even if a newer version was requested, it wouldn't be installed. This is really down to the underlying tool and how it works, but smarts have now been put into the module, to check installed version, against what is requested, so that an uninstall is first executed, and then the requested version is installed.
…le to target Cake v1.0.0
This is known issue with Cake, that will hopefully be addressed in the future.
augustoproiete
force-pushed
the
feature/gh-2685
branch
from
90aebef to
d62388b
Compare
devlead
force-pushed
the
feature/gh-2685
branch
from
d62388b to
90df47a
Compare
augustoproiete
approved these changes
Feb 27, 2021
There was a problem hiding this comment.
LGTM!
Tested with a number of .NET tools and it works as expected:
#tool dotnet:?package=GitVersion.Tool&version=5.1.2
#tool dotnet:?package=exceldna-unpack&version=2.1.0
#tool dotnet:?package=minver-cli&version=2.4.0
#tool dotnet:?package=dotnet-reportgenerator-globaltool&version=4.8.6
Test 1 - First run without any tools installed installs them as expected:
Test 2 - Second run with the tools already installed displays informational message that tools are already installed as expected
(perhaps something we could make verbose in a future PR?)
Test 3 - Deleted tools folder, added cake.config with different path for tools folder, installs as expected honoring the cake.config tools path
cake.config
[Paths]
Tools=./MyCustomTools
Addins=./MyCurtomAddins
Modules=./MyCustomModules
Test 4 - Including Cake.DotNetTool.Module in a Cake script now displays a warning explaining it's no longer needed
#module nuget:?package=Cake.DotNetTool.Module&version=1.0.1
This was referenced Feb 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2685 and #2903