(GH-2685) Clean up Unit tests

Author: devlead

src/Cake.DotNetTool.Module.Tests/Cake.DotNetTool.Module.Tests.csproj

@@ -1,17 +1,21 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
+    <AssemblyName>Cake.DotNetTool.Module.Tests</AssemblyName>
     <TargetFrameworks>net461;netcoreapp2.1;netcoreapp3.1;net5.0</TargetFrameworks>
-    <DebugType>full</DebugType>
-    <IsPackable>false</IsPackable>
+    <GenerateRuntimeConfigurationFiles>true</GenerateRuntimeConfigurationFiles>
+    <IsCakeTestProject>true</IsCakeTestProject>
   </PropertyGroup>
-
+  <!-- Import shared functionality -->
+  <Import Project="..\Shared.msbuild" />
+  <!-- Project references -->
   <ItemGroup>
     <ProjectReference Include="..\Cake.Core\Cake.Core.csproj" />
-    <ProjectReference Include="..\Cake.NuGet\Cake.NuGet.csproj" />
+    <ProjectReference Include="..\Cake.DotNetTool.Module\Cake.DotNetTool.Module.csproj" />
     <ProjectReference Include="..\Cake.Testing\Cake.Testing.csproj" />
     <ProjectReference Include="..\Cake.Testing.Xunit\Cake.Testing.Xunit.csproj" />
   </ItemGroup>
+  <!-- Global packages -->
   <ItemGroup>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.9.1" />
     <PackageReference Include="xunit" Version="2.4.1" />
@@ -20,10 +24,6 @@
       <IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
     </PackageReference>
     <PackageReference Include="NSubstitute" Version="4.2.2" />
+    <PackageReference Include="Castle.Core" Version="4.4.1" />
   </ItemGroup>
-
-  <ItemGroup>
-    <ProjectReference Include="..\Cake.DotNetTool.Module\Cake.DotNetTool.Module.csproj" />
-  </ItemGroup>
-
 </Project>

src/Cake.DotNetTool.Module.Tests/DotNetToolPackageInstallerFixture.cs

@@ -1,11 +1,11 @@
-using Cake.Core;
+using System.Collections.Generic;
+using Cake.Core;
 using Cake.Core.Configuration;
 using Cake.Core.Diagnostics;
 using Cake.Core.IO;
 using Cake.Core.Packaging;
 using Cake.Testing;
 using NSubstitute;
-using System.Collections.Generic;
 
 namespace Cake.DotNetTool.Module.Tests
 {

src/Cake.DotNetTool.Module.Tests/DotNetToolPackageInstallerTests.cs

@@ -1,9 +1,5 @@
-using Cake.Core.Diagnostics;
-using Cake.Core.IO;
+using System;
 using Cake.Core.Packaging;
-using NSubstitute;
-using System;
-using System.Collections.Generic;
 using Xunit;
 
 namespace Cake.DotNetTool.Module.Tests