Skip to content

Make PROXY_ROOT_DOMAIN required #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2018
Merged

Make PROXY_ROOT_DOMAIN required #92

merged 1 commit into from
Oct 15, 2018

Conversation

snebel29
Copy link
Contributor

Problem

PROXY_ROOT_DOMAIN should be required as documented, as describe here #39

Solution

Making that parameter required following the same patter as for others

@shrayolacrayon
Copy link

Thank you for this contribution @snebel29!

@shrayolacrayon shrayolacrayon merged commit 3a64e69 into buzzfeed:master Oct 15, 2018
@snebel29 snebel29 deleted the fix/proxy_root_domain_required_issue_39 branch October 15, 2018 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrayolacrayon shrayolacrayon shrayolacrayon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snebel29 @shrayolacrayon