Skip to content

Commit 3a64e69

Browse files
author
Shraya Ramani
authored
Merge pull request #92 from snebel29/fix/proxy_root_domain_required_issue_39
Make PROXY_ROOT_DOMAIN required
2 parents 0519150 + a674aee commit 3a64e69

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

internal/auth/options.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,9 @@ func (o *Options) Validate() error {
157157
if len(o.EmailDomains) == 0 {
158158
msgs = append(msgs, "missing setting for email validation: email-domain required.\n use email-domain=* to authorize all email addresses")
159159
}
160+
if len(o.ProxyRootDomains) == 0 {
161+
msgs = append(msgs, "missing setting: proxy-root-domain")
162+
}
160163
if o.ProxyClientID == "" {
161164
msgs = append(msgs, "missing setting: proxy-client-id")
162165
}

internal/auth/options_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ func testOptions() *Options {
1818
o.EmailDomains = []string{"*"}
1919
o.ProxyClientID = "abcdef"
2020
o.ProxyClientSecret = "testtest"
21+
o.ProxyRootDomains = []string{"*"}
2122
o.StatsdHost = "statsdhost"
2223
o.StatsdPort = 12344
2324
o.Host = "/"
@@ -43,6 +44,7 @@ func TestNewOptions(t *testing.T) {
4344
"missing setting: cookie-secret",
4445
"missing setting: client-id",
4546
"missing setting: client-secret",
47+
"missing setting: proxy-root-domain",
4648
"missing setting: proxy-client-id",
4749
"missing setting: proxy-client-secret",
4850
"missing setting: required-host-header",

0 commit comments

Comments
 (0)