Skip to content

DDO-4137 update to read artifacts from GAR #9198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

ungwudik
Copy link

@ungwudik ungwudik commented Jun 3, 2025

JIRA ticket https://broadworkbench.atlassian.net/browse/DDO-4137

Summary of changes
Updated the artifact source for this service to read artifacts from Google Artifact Registry instead of JFrog.

What
Modified the config to pull artifacts from GAR. No publishing changes were made.

Why
This is part of Phase 2 of the artifact migration effort to deprecated JFrog and consolidate artifacts in GAR.

Testing these changes
Relied on passing CI checks and tests. Artifact reading-related issues are expected to surface as pipeline failures. For example these jobs here and here failed due to access issues (which have since been resolved).

@ungwudik ungwudik marked this pull request as ready for review June 4, 2025 15:50
Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ungwudik Thanks for this. It doesn't work though without more changes. Do you know how authentication is handled for it? Is this a google repository? Is it public? I can't view anything at https://us-central1-maven.pkg.dev/dsp-artifact-registry/libs-snapshot or https://us-central1-maven.pkg.dev/dsp-artifact-registry/`. It just gives me 404.

I tried publishing to their and I get:

Execution failed for task ':publishGatkPublicationToArtifactoryRepository'.
> Failed to publish publication 'gatk' to repository 'Artifactory'
   > Could not write to resource 'https://us-central1-maven.pkg.dev/dsp-artifact-registry/libs-snapshot/org/broadinstitute/gatk/4.6.2.0-7-g342fa26-SNAPSHOT/gatk-4.6.2.0-7-g342fa26-20250605.165244-1.jar'.
      > Broken pipe

@ungwudik
Copy link
Author

ungwudik commented Jun 9, 2025

@ungwudik Thanks for this. It doesn't work though without more changes. Do you know how authentication is handled for it? Is this a google repository? Is it public? I can't view anything at https://us-central1-maven.pkg.dev/dsp-artifact-registry/libs-snapshot or https://us-central1-maven.pkg.dev/dsp-artifact-registry/`. It just gives me 404.

I tried publishing to their and I get:

Execution failed for task ':publishGatkPublicationToArtifactoryRepository'.
> Failed to publish publication 'gatk' to repository 'Artifactory'
   > Could not write to resource 'https://us-central1-maven.pkg.dev/dsp-artifact-registry/libs-snapshot/org/broadinstitute/gatk/4.6.2.0-7-g342fa26-SNAPSHOT/gatk-4.6.2.0-7-g342fa26-20250605.165244-1.jar'.
      > Broken pipe

Sorry, I had not intended to change the publishing part. This PR is for migrating only the "read" part. Publishing for services/repo will be addressed in a later phase by the service/repo-owning teams, with guidance from DevOps. A lot more details/context in this document

For read access check, please try curling a specific artifact such as https://us-central1-maven.pkg.dev/dsp-artifact-registry/libs-snapshot/org/broadinstitute/gatk/4.6.0.0-20-g2f15726-SNAPSHOT/gatk-4.6.0.0-20-g2f15726-20241011.180722-1-javadoc.jar

OR

try accessing the repositories via cloud console and let me know if you can view the pages. But please note that access may be delayed for some people until this ticket is completed.
https://console.cloud.google.com/artifacts/maven/dsp-artifact-registry/
https://console.cloud.google.com/artifacts/maven/dsp-artifact-registry/us-central1/libs-snapshot/

Thanks for reviewing!

@ungwudik ungwudik requested a review from lbergelson June 9, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants