Skip to content

Decode HTML entities in getChannelNameFromResponse(). #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

szilardszaloki
Copy link
Contributor

@szilardszaloki szilardszaloki commented Feb 3, 2022

Resolves brave/brave-browser#19594.

Test Plan:

On dev: Brave Local Data Updater - Version: (>=) 1.0.190
lola

emerick
emerick previously approved these changes Feb 3, 2022
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zenparsing
zenparsing previously approved these changes Feb 3, 2022
@szilardszaloki szilardszaloki dismissed stale reviews from zenparsing and emerick via 6781c45 February 3, 2022 15:27
@szilardszaloki szilardszaloki force-pushed the sszaloki-19594-decode-html-entities-in-getChannelNameFromResponse branch from 5e5ed46 to 6781c45 Compare February 3, 2022 15:27
@emerick emerick self-requested a review February 3, 2022 15:46
@szilardszaloki szilardszaloki merged commit 589fef5 into master Feb 9, 2022
@szilardszaloki szilardszaloki deleted the sszaloki-19594-decode-html-entities-in-getChannelNameFromResponse branch February 9, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apostrophe not being unescaped in YouTube channel name
3 participants