Skip to content

Apostrophe not being unescaped in YouTube channel name #19594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Miyayes opened this issue Nov 19, 2021 · 2 comments · Fixed by brave/brave-site-specific-scripts#66
Closed

Apostrophe not being unescaped in YouTube channel name #19594

Miyayes opened this issue Nov 19, 2021 · 2 comments · Fixed by brave/brave-site-specific-scripts#66

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Nov 19, 2021

Description

Apostrophe is appearing as #39; instead of an apostrophe ' in YouTube channel name.

Example: https://www.youtube.com/c/LolasLifeLessons

image

@LaurenWags
Copy link
Member

LaurenWags commented Feb 11, 2022

Verified using

Brave | 1.35.101 Chromium: 98.0.4758.87 (Official Build) (x86_64)
-- | --
Revision | e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS | macOS Version 12.2.1 (Build 21D62)

and the below dev component:

Brave Local Data Updater - Version: 1.0.196

Screen Shot 2022-02-11 at 3 45 45 PM

For a new profile only, confirmed the apostrophe is showing correctly on panel for above creator:

Screen Shot 2022-02-11 at 3 22 14 PM

Note, existing profiles will still show the unescaped apostrophe due to #20980.

Additionally, spot checked a few other creators panels (on new profile) to confirm they showed ok:

Example Example Example Example
1 2 3 4

Note, found sites for production using bravebat.info.
Encountered and logged #21062 for other characters not being handled properly on the panel.


Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.35.101 Chromium: 98.0.4758.87 (Official Build) (64-bit)
-- | --
Revision | e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS | Windows 11 Version 21H2 (Build 22000.493)

Went through the following verification using Brave Local Data Updater - Version: 1.0.199 as per the following:

image

For a new profile only, confirmed the apostrophe is showing correctly on panel for above creator:

image

Example Example Example Example Example
image image image image image

@kjozwiak
Copy link
Member

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.35.101 Chromium: 98.0.4758.87 (Official Build) (64-bit)
-- | --
Revision | e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS | Windows 11 Version 21H2 (Build 22000.493)

Went through the following verification using Brave Local Data Updater - Version: 1.0.71 as per the following:

image

For a new profile only, confirmed the apostrophe is showing correctly on panel for above creator:

image

Example Example Example
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants