This repository was archived by the owner on Jun 6, 2019. It is now read-only.
Update brave-ui to v0.10.6 + Tests #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cezaraugusto
force-pushed
the
brave-ui/v0.10.5
branch
from
ce9c8eb to
c69afe0
Compare
cezaraugusto
force-pushed
the
brave-ui/v0.10.5
branch
from
c69afe0 to
d8184d1
Compare
|
I'm good with this PR, please help create a follow up issue for the visual regression of different button size I'm seeing per offline discussion, thanks! |
yrliou
approved these changes
Jun 13, 2018
cezaraugusto
changed the title
|
ok re #34 (comment) added f74d944 as a fix |
|
confirmed the fix works for me |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates
brave-uiwhich was using an outdated API. This also includes Enzyme support for testing.Test plan: