Skip to content

Shields panel has extra padding to right #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
srirambv opened this issue May 24, 2018 · 5 comments · Fixed by brave/brave-extension#52
Closed

Shields panel has extra padding to right #222

srirambv opened this issue May 24, 2018 · 5 comments · Fixed by brave/brave-extension#52
Assignees
@cezaraugusto
Labels
bug feature/shields The overall Shields feature in Brave. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@srirambv
Copy link
Contributor

Description

Shields panel doesn't fit in

Steps to Reproduce

  1. Build from source( 46eacca)
  2. Visit any site and open shields
  3. Has extra padding to right causing

Actual result:

image

Expected result:

Should not contain extra padding

Reproduces how often:

Easy

Brave version (about:brave info)

Reproducible on current release:

Website problems only:

  • Does the issue gets fixed with Brave Shields disabled?
  • Does the issue reproduces on Chrome?

Additional Information
@srirambv srirambv added bug feature/shields The overall Shields feature in Brave. labels May 24, 2018
@cezaraugusto cezaraugusto mentioned this issue Jun 12, 2018
Merged
@yrliou yrliou removed their assignment Jul 1, 2018
@cezaraugusto
Copy link
Contributor

@srirambv can you confirm this is still a bug?

if so could you please try opening dev tools from inside the extension popup and looking for the <body> tag and remove the property width and adding it to the data-test-id braveShieldsPanel instead to see if this solves the issue? Something similar to the below screenshot. This doesn't seem to reproduce on macOS.

screen shot 2018-07-26 at 11 52 16 am

** note that has width: auto and braveShieldsPanel has the current 280px

If it does fix it please let me know I can help you cook a PR for it. Thanks!

@srirambv
Copy link
Contributor Author

srirambv commented Aug 2, 2018

@cezaraugusto this is what i get with the above settings
image

@srirambv srirambv mentioned this issue Aug 3, 2018
Closed
@emerick
Copy link
Contributor

emerick commented Aug 3, 2018

@cezaraugusto I see it as well on Windows. I think the scrollbar is to blame somehow, as when I collapse the "Advanced Controls" section the scrollbar (and the extra space on the right) both go away.

cezaraugusto added a commit to brave/brave-extension that referenced this issue Aug 10, 2018
@cezaraugusto
prevent scrollbar in the extension container
b92e9c4 
-
fix brave/brave-browser#222
@cezaraugusto cezaraugusto mentioned this issue Aug 10, 2018
Merged
@bbondy bbondy added the QA/Yes label Aug 17, 2018
@lukemulks
Copy link

shield-padding-and-scroll

FYI - I'm seeing the scrolling and the padding on win10 x64.

I believe I'm on the latest build. If I'm not on the latest build, disregard. I'm not re-opening this issue, just in case this is resolved and I am just not updated.

Here's what I'm getting for about:brave

Brave is up to date
Version 0.54.0 Chromium: 69.0.3497.32 (Official Build) dev (64-bit)

@srirambv srirambv mentioned this issue Aug 18, 2018
Closed
Snuupy pushed a commit to Snuupy/brave-extension that referenced this issue Aug 21, 2018
@cezaraugusto
prevent scrollbar in the extension container
07056c9 
-
fix brave/brave-browser#222
@btlechowski
Copy link

btlechowski commented Sep 21, 2018 •
edited by LaurenWags
Loading

Verification passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

Extra padding in not shown even when clicked on blocked element #771
222_pass

Verification Passed on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Verified passed with

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Mac OS X

@bbondy bbondy added QA/Yes and removed QA/Yes labels Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
bug feature/shields The overall Shields feature in Brave. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

prevent scrollbar in the extension container across OSes brave/brave-extension
8 participants
@bbondy @cezaraugusto @yrliou @emerick @lukemulks @srirambv @LaurenWags @btlechowski