Skip to content

Allow only IPNS and domain names in rewards #9375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 16, 2021
Merged

Allow only IPNS and domain names in rewards #9375

merged 2 commits into from
Jul 16, 2021

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Jul 8, 2021 •
edited
Loading

Resolves brave/brave-browser#16612

  • Allow only IPNS and domain names in rewards

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • open ipns://browsers.today
  • open rewards popup, should show browsers.today
  • open ipns://k2k4r8oj77eqrr4018u3qjk2byycrz4pmxyodaruuqv4zvph6foed004/ and check it doesnt appear in rewards panel

@spylogsster spylogsster requested a review from a team as a code owner July 8, 2021 16:57
@spylogsster spylogsster requested review from emerick and deeppandya July 8, 2021 16:57
@spylogsster spylogsster marked this pull request as draft July 8, 2021 16:57
@spylogsster spylogsster requested a review from bridiver July 8, 2021 21:21
@spylogsster spylogsster marked this pull request as ready for review July 8, 2021 21:32
@spylogsster spylogsster changed the title Allow only IPNS and domain names in rewards Allow only IPNS and domain names in rewards (not ready yet) Jul 9, 2021
@spylogsster spylogsster changed the title Allow only IPNS and domain names in rewards (not ready yet) Allow only IPNS and domain names in rewards Jul 11, 2021
@spylogsster spylogsster force-pushed the issue-16612-2 branch 7 times, most recently from 993ebdc to acbad4b Compare July 12, 2021 20:06
@spylogsster spylogsster requested a review from a team as a code owner July 13, 2021 20:05
@spylogsster spylogsster force-pushed the issue-16612-2 branch 3 times, most recently from 3d29fbe to ee4e002 Compare July 14, 2021 11:06
@bbondy bbondy merged commit 6ba2c82 into master Jul 16, 2021
@bbondy bbondy deleted the issue-16612-2 branch July 16, 2021 17:51
@bbondy bbondy added this to the 1.29.x - Nightly milestone Jul 16, 2021
@yrliou yrliou mentioned this pull request Sep 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridiver bridiver bridiver approved these changes

@emerick emerick Awaiting requested review from emerick

@deeppandya deeppandya Awaiting requested review from deeppandya

Assignees

@spylogsster spylogsster

Labels
None yet
Projects
None yet
Milestone
1.29.x - Release
Development

Successfully merging this pull request may close these issues.

Rewards panel doesn't list IPFS links fully in panel
3 participants
@spylogsster @bridiver @bbondy