Skip to content

Cert invalid error when visiting *.eth.link #17815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yrliou opened this issue Sep 1, 2021 · 2 comments · Fixed by brave/brave-core#9951
Closed

Cert invalid error when visiting *.eth.link #17815

yrliou opened this issue Sep 1, 2021 · 2 comments · Fixed by brave/brave-core#9951

Comments

@yrliou
Copy link
Member

yrliou commented Sep 1, 2021

Description

brave/brave-core#9375 adds eth.link into public suffix list and we will have cert invalid error when visiting *.eth.link.

Steps to Reproduce

  1. Visit https://swapr.eth.link/

Actual result:

Screen Shot 2021-09-01 at 3 49 20 PM

Expected result:

Screen Shot 2021-09-01 at 3 50 44 PM

Reproduces how often:

Always

Version/Channel Information:

Starting from 1.29.x

@stephendonner
Copy link

Thanks for flagging, filing, and fixing, @yrliou 🤜 🤛

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 8, 2021

Verification passed on


Brave | 1.29.79 Chromium: 93.0.4577.63 (Official Build) (64-bit)
-- | --
Revision | ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS | Windows 10 OS Version 2009 (Build 19043.1165)


Verification passed on

Brave 1.29.79 Chromium: 93.0.4577.63 (Official Build) (64-bit)
Revision ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS Ubuntu 18.04 LTS

Verified the test plan from brave/brave-core#9951

image


Verified passed with

Brave | 1.29.79 Chromium: 93.0.4577.63 (Official Build) (x86_64)
-- | --
Revision | ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS | macOS Version 10.15.7 (Build 19H1323)
Example Example Example
1 2 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment