Skip to content

resolves issue #14596, change Add Site to Add site #9306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 2, 2021
Merged

resolves issue #14596, change Add Site to Add site #9306

merged 1 commit into from
Jul 2, 2021

Conversation

akshat-rawat
Copy link
Contributor

@akshat-rawat akshat-rawat commented Jul 1, 2021

Resolves #14596

Submitter Checklist:

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See brave/brave-browser#14596

Copy link
Contributor

@stephendonner stephendonner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ thanks!

@stephendonner stephendonner merged commit f72bd5c into brave:master Jul 2, 2021
@bbondy bbondy added this to the 1.28.x - Nightly milestone Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Site should probably read Add site in new-tab page's Favorites
3 participants