Skip to content

Add Site should probably read Add site in new-tab page's Favorites #14596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
stephendonner opened this issue Mar 9, 2021 · 5 comments · Fixed by brave/brave-core#9306
Closed
Assignees
Labels
feature/new-tab good first issue needs-text-change This change requires some careful wording. OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Yes release-notes/exclude

Comments

@stephendonner
Copy link

Description

Add Site should probably read Add site in new-tab page's Favorites

Steps to Reproduce

  1. open the new-tab page
  2. click Customize
  3. choose Top Sites from the left
  4. choose Favorites
  5. dismiss the dialog
  6. hover to the right of the Add site button
  7. click on the ellipsis
  8. note the capitalization of Add Site

Actual result:

It reads Add Site (upper-case)

Screen Shot 2021-03-09 at 11 14 11 AM

Expected result:

Add site (lower-case)

Reproduces how often:

Brave version (brave://version info)

Brave 1.22.55 Chromium: 89.0.4389.72 (Official Build) beta (x86_64)
Revision 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS macOS Version 11.2.3 (Build 20D91)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no
  • Can you reproduce this issue with the beta channel? no
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@bsclifton bsclifton added the needs-text-change This change requires some careful wording. label Mar 10, 2021
@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". polish Nice to have — usually related to front-end/visual tasks release-notes/exclude labels Mar 15, 2021
@akshat-rawat
Copy link

Hi, I would like the work on the issue.
Acc. to me the cause of the issue is in brave-core/components/resources/brave_components_strings.grd

@stephendonner
Copy link
Author

Assigning to you @akshat-rawat; thanks for taking a look!

@akshat-rawat
Copy link

@stephendonner, I have made the necessary changes and opened a PR for the same.

@stephendonner
Copy link
Author

@stephendonner, I have made the necessary changes and opened a PR for the same.

Thanks for fixing; reviewed and merged!

@stephendonner stephendonner added this to the 1.28.x - Nightly milestone Jul 2, 2021
@stephendonner
Copy link
Author

Verified FIXED using the inline testplan with build

Brave 1.28.54 Chromium: 92.0.4515.81 (Official Build) nightly (x86_64)
Revision dba3af0a9a48954c8b188bc641e651580b7cb7b5-refs/branch-heads/4515@{#1162}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. open the new-tab page
  2. click Customize
  3. choose Top Sites from the left
  4. choose Favorites
  5. dismiss the dialog
  6. hover to the right of the Add site button
  7. click on the ellipsis ...

Confirmed it now reads Add site

Screen Shot 2021-07-06 at 4 47 24 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/new-tab good first issue needs-text-change This change requires some careful wording. OS/Desktop polish Nice to have — usually related to front-end/visual tasks priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants