Skip to content

update brave-ui to 0.33.x #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2018
Merged

update brave-ui to 0.33.x #839

merged 1 commit into from
Nov 8, 2018

Conversation

cezaraugusto
Copy link
Contributor

fix brave/brave-browser#2052
closes brave/brave-browser#2053

Test Plan:

npm run test-unit

jasonrsadler
jasonrsadler previously approved these changes Nov 8, 2018
Copy link
Contributor

@jasonrsadler jasonrsadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit tests now work ++

- also allow jest to transpile es6 modules in js/jsx for brave-ui
Copy link
Contributor

@jasonrsadler jasonrsadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis does not pass without js|jsx

++ Good job @cezaraugusto

@jasonrsadler jasonrsadler merged commit 32c990c into master Nov 8, 2018
@jasonrsadler jasonrsadler deleted the brave-ui-33-jest branch November 8, 2018 19:48
@jasonrsadler
Copy link
Contributor

jasonrsadler commented Nov 8, 2018

master (0.59.x): 32c990c
0.58.x 874c488

@cezaraugusto
Copy link
Contributor Author

cezaraugusto commented Nov 8, 2018

0.57.x 2f96136

@kjozwiak
Copy link
Member

Approved uplift to 0.57.x after deliberating with @srirambv & @rebron 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update brave-ui to 0.33.x updating brave-ui to v0.33.x breaks tests
5 participants