Skip to content

Hide unwanted sublabel on Clear on Exit toggle button #17032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 4, 2023

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Feb 3, 2023

Resolves brave/brave-browser#28269

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@emerick emerick requested a review from mkarolin February 3, 2023 22:21
@emerick emerick self-assigned this Feb 3, 2023
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Feb 3, 2023
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@emerick emerick merged commit 70ea00e into master Feb 4, 2023
@emerick emerick deleted the cr110-followup-remove-clear-on-exit-sublabel branch February 4, 2023 02:53
@emerick emerick added this to the 1.50.x - Nightly milestone Feb 4, 2023
brave-builds added a commit that referenced this pull request Feb 4, 2023
brave-builds added a commit that referenced this pull request Feb 4, 2023
@stephendonner
Copy link
Contributor

Verified PASSED using

Brave 1.50.9 Chromium: 110.0.5481.77 (Official Build) nightly (x86_64)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS macOS Version 11.7.3 (Build 20G1116)

Steps:

  1. installed 1.50.9
  2. launched Brave
  3. opened brave://settings/cookies
  4. looked at the Clear cookies and site data when you close all windows pref

Confirmed there no longer is the (literal) subtext of When on, you'll also be signed out of Brave.

1.50.9 1.48.152
Screen Shot 2023-02-04 at 8 42 27 PM Screen Shot 2023-02-04 at 8 44 02 PM

@kjozwiak
Copy link
Member

kjozwiak commented Feb 6, 2023

Verification PASSED on Win 11 x64 using the following build(s):

Brave | 1.50.11 Chromium: 110.0.5481.77 (Official Build) nightly (64-bit)
-- | --
Revision | 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS | Windows 11 Version 22H2 (Build 22621.1194)
1.50.6 Chromium: 110.0.5481.77 1.50.11 Chromium: 110.0.5481.77
reproducedIssue1 fixedCookies

kjozwiak pushed a commit that referenced this pull request Feb 6, 2023
kjozwiak pushed a commit that referenced this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

description text for "Clear cookies and site data..." doesn't make sense
5 participants