Skip to content

Refactor settings for IPFS into its own section #7848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2021

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Feb 5, 2021

Resolves brave/brave-browser#13682
Refactor settings for IPFS into its own section

image

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • [x Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@spylogsster spylogsster requested a review from bbondy February 5, 2021 14:10
@spylogsster spylogsster requested a review from a team as a code owner February 5, 2021 14:10
@spylogsster spylogsster force-pushed the add-ipfs-settings-section branch 4 times, most recently from 881b583 to f3ad9af Compare February 5, 2021 22:28
@bbondy
Copy link
Member

bbondy commented Feb 6, 2021

Could you put the new IPFS one below the Extensions one?

@spylogsster spylogsster force-pushed the add-ipfs-settings-section branch from f3ad9af to e336ec6 Compare February 6, 2021 06:03
@spylogsster
Copy link
Contributor Author

Could you put the new IPFS one below the Extensions one?

done

@spylogsster spylogsster force-pushed the add-ipfs-settings-section branch 2 times, most recently from a2f2e05 to 6a458cb Compare February 6, 2021 15:24
@spylogsster spylogsster force-pushed the add-ipfs-settings-section branch from 6a458cb to 868d0fc Compare February 6, 2021 15:25
Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@bbondy bbondy merged commit 57fdf2f into master Feb 7, 2021
@bbondy bbondy deleted the add-ipfs-settings-section branch February 7, 2021 01:02
@bbondy bbondy added this to the 1.22.x - Nightly milestone Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor settings for IPFS into its own section
2 participants