Skip to content

Refactor settings for IPFS into its own section #13682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bbondy opened this issue Jan 20, 2021 · 3 comments · Fixed by brave/brave-core#7848
Closed

Refactor settings for IPFS into its own section #13682

bbondy opened this issue Jan 20, 2021 · 3 comments · Fixed by brave/brave-core#7848
Assignees
@spylogsster
Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/include
Milestone
1.22.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Jan 20, 2021

Add a local node option:
Screen Shot 2021-01-20 at 11 13 51 AM
@bbondy bbondy added OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. labels Jan 20, 2021
@jessicaschilling
Copy link

LGTM! But what happened to this section?
image

@bbondy
Copy link
Member Author

bbondy commented Jan 20, 2021

Yep! All the settings will still be there, the above image is just for reference for how it will look overall.

@spylogsster spylogsster self-assigned this Feb 4, 2021
@spylogsster spylogsster mentioned this issue Feb 5, 2021
Merged
22 tasks
@bbondy bbondy added this to the 1.22.x - Nightly milestone Feb 7, 2021
@stephendonner
Copy link

Verified FIXED using nightly on macOS Big Sur (11.2.1) with

Brave 1.22.39 Chromium: 89.0.4389.58 (Official Build) nightly (x86_64)
Revision 1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS macOS Version 11.2.1 (Build 20D74)

Screen Shot 2021-02-22 at 2 50 16 PM

Tested and verified that the settings generally work (i.e. I didn't go too deeply), while testing other IPFS issues.

@LaurenWags LaurenWags mentioned this issue Mar 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spylogsster spylogsster

Labels
OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Yes release-notes/include
Projects
None yet
Milestone
1.22.x - Release
Development

Successfully merging a pull request may close this issue.

Refactor settings for IPFS into its own section brave/brave-core
4 participants
@stephendonner @bbondy @jessicaschilling @spylogsster