Skip to content

[Android] Fixed homepage settings for tablets #7802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

samartnik
Copy link
Contributor

@samartnik samartnik commented Feb 3, 2021

Resolves brave/brave-browser#13931

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@samartnik samartnik added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Feb 3, 2021
@samartnik samartnik added this to the 1.21.x - Nightly milestone Feb 3, 2021
@samartnik samartnik self-assigned this Feb 3, 2021
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@samartnik samartnik merged commit cd3aec9 into master Feb 3, 2021
@samartnik samartnik deleted the android_home_settings_tablet branch February 3, 2021 19:39
brave-builds pushed a commit that referenced this pull request Feb 3, 2021
brave-builds pushed a commit that referenced this pull request Feb 3, 2021
samartnik pushed a commit that referenced this pull request Feb 3, 2021
samartnik pushed a commit that referenced this pull request Feb 3, 2021
@srirambv
Copy link
Contributor

srirambv commented Feb 4, 2021

Verification passed on Samsung Tab A with Android 10 running 1.21.1 x64 Nightly build

  • Verified home button setting is available under Controls in menu
  • Verified able to disable and re-enable home button without any issue/crash
  • Verified disable/re-enable home button and tapping on it loads the home page and doesn't cause any crash
Tablet.Home.button.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Home button option missing from Tablets
3 participants