Skip to content

Home button option missing from Tablets #13931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
srirambv opened this issue Feb 3, 2021 · 2 comments · Fixed by brave/brave-core#7802
Closed

Home button option missing from Tablets #13931

srirambv opened this issue Feb 3, 2021 · 2 comments · Fixed by brave/brave-core#7802
Assignees
@samartnik
Labels
android-tablet-specific bug OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes regression release/blocking release-notes/exclude
Milestone
1.19.x - Release #4

Comments

@srirambv
Copy link
Contributor

srirambv commented Feb 3, 2021

Description

Home button option missing from Tablets

Steps to reproduce

  1. Install 1.19.90 x64 build
  2. Go to Settings
  3. No option for Home button under Controls
Actual result Expected result

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet):Tablet
  • Android version: 10

Brave version

1.19.90

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information
@srirambv srirambv mentioned this issue Feb 3, 2021
Closed
@GeetaSarvadnya
Copy link

Reproduced in Samsung Galaxy Tablet version 10 - Brave 1.19.90

@samartnik samartnik self-assigned this Feb 3, 2021
@samartnik samartnik mentioned this issue Feb 3, 2021
Merged
23 tasks
This was referenced Feb 3, 2021
Closed
Merged
@samartnik samartnik mentioned this issue Feb 3, 2021
Merged
4 tasks
This was referenced Feb 4, 2021
Closed
Closed
@srirambv
Copy link
Contributor Author

srirambv commented Feb 4, 2021 •
edited by GeetaSarvadnya
Loading

Verification passed on Samsung Tab A with Android 10 running 1.19.91 x64 build

  • Verified Home button option is still there under controls in menu
  • Verified disabling and re-enabling home button doesn't cause any crash
  • Verified tapping home button loads the set page
  • Verified upgrading from GPS version and selecting home button doesn't cause any crash
Tab.home.button.mp4

Verification passed on OnePlus 6T with Android 10 running 1.19.91 x64 build

  • Verified home button works as expected on ARM device
  • Verified disabling bottom toolbar hides home button menu under controls
  • Verified clicking on home button laods the home page and doesn't crash

Verification passed on Samsung Galaxy Tab with Android 10 running Bravemonoarm64.apk_1.19.91 build

  • Verified Home button option is still there under controls in menu
  • Verified disabling and re-enabling home button doesn't cause any crash
  • Verified tapping home button loads the set page
  • Verified upgrading from GPS version and selecting home button doesn't cause any crash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samartnik samartnik

Labels
android-tablet-specific bug OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes regression release/blocking release-notes/exclude
Projects
None yet
Milestone
1.19.x - Release #4
Development

Successfully merging a pull request may close this issue.

[Android] Fixed homepage settings for tablets brave/brave-core
4 participants
@kjozwiak @srirambv @samartnik @GeetaSarvadnya