Change ipfs scheme handling #7785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spylogsster
force-pushed
the
change-ipfs-scheme-handling
branch
from
f7bff1f to
9356bb4
Compare
bbondy
requested changes
Feb 3, 2021
spylogsster
force-pushed
the
change-ipfs-scheme-handling
branch
from
9356bb4 to
8c64443
Compare
bbondy
requested changes
Feb 3, 2021
spylogsster
force-pushed
the
change-ipfs-scheme-handling
branch
7 times, most recently
from
e9a9740 to
d496806
Compare
bbondy
approved these changes
Feb 4, 2021
spylogsster
force-pushed
the
change-ipfs-scheme-handling
branch
7 times, most recently
from
e248a44 to
9499570
Compare
bbondy
added
CI/skip-android
We should change this to only keep ipfs:// and ipns:// when the address being loaded when: i) Using the Brave node and the port matches the Brave node's port. ii) Using the public node and the port matches the public node, and it is localhost. iii) When user enters custom public gateway Brave should always replace raw IP (127.0.0.1) with localhost, as that enables subdomains and origin isolation. Raw IP can't have subdomains and all content roots share the same origin, which we don't want in browser.
bbondy
force-pushed
the
change-ipfs-scheme-handling
branch
from
9499570 to
cd2b323
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#13872
We should change this to only keep ipfs:// and ipns:// when the address being loaded when:
i) Using the Brave node and the port matches the Brave node's port.
ii) Using the public node and the port matches the public node, and it is localhost.
iii) When user enters custom public gateway Brave should always replace raw IP (127.0.0.1) with localhost, as that enables subdomains and origin isolation. Raw IP can't have subdomains and all content roots share the same origin, which we don't want in browser.
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed).Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on.
Test Plan:
Described here brave/brave-browser#13872