-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[Security] Improve handling of address bar display for IPFS and IPNS #13872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Two nits regarding "Test case 2"
|
Verified
Verified the inline testcases, and filed #14499 about the IPFS URI ( Test case 1: Non configured localhost should never show as IPFS
Test case 2: Public gateway
Test case 3:
Verification passed on
Verified test plan from the description #14499 about the IPFS URI ( Test case 1: Non configured localhost should never show as IPFS
Test case 2: Public gateway
Encountered #14499 Test case 3:
Verification is inprogress
Test case 1: Non configured localhost should never show as IPFS
Test case 2: Public gateway
Note : The source Test case 3:
|
Adding |
Currently
http://test.com.ipns.localhost:8000
shows in the address address bar asipns://test.com
.However test.com is neither a valid CID nor a DNSLink resolution.
There's also a problem that people that run their own local node, want to retain
ipfs://
in their URL bar, but they can't set it as the default gateway.Currently, we only update the address bar to retain
ipfs://
andipns://
when the user is using the configured Brave node and it is localhost.We should change this to only keep
ipfs://
andipns://
when the address being loaded when:i) Using the Brave node and the port matches the Brave node's port.
ii) Using the public node and the port matches the public node, and it is localhost. (Currently we don't do this, so this is new)
This means that something that is not running a gateway that is configured in Brave will not retain
ipfs://
anymore like it does with an example local server likehttp://test.com.ipns.localhost:8000
Test cases:
Test case 1: Non configured localhost should never show as IPFS
test.com.ipns.localhost
http://test.com.ipns.localhost:8000
, it should retain that addressTest case 2: Public gateway
http://127.0.0.1:8080/ipfs/QmV4FVfWRG4hJJKUsS1aU9MK85HYFJtuCmYAj8HetS8qMS
. It should load the content but retain thehttps://dweb.link/ipfs/QmV4FVfWRG4hJJKUsS1aU9MK85HYFJtuCmYAj8HetS8qMS
URL in the address bar.http://127.0.0.1:8080
in settings. And also set Brave to use this public gateway when resolving IPFS URIs.https://dweb.link/ipfs/QmV4FVfWRG4hJJKUsS1aU9MK85HYFJtuCmYAj8HetS8qMS
. It should update to anipfs://
URI.Test case 3:
ipns://brantly.eth
ipns://brantly.eth
in the address bar.http://brantly.eth.ipns.localhost:48081/
ipns://brantly.eth
in the address bar.The text was updated successfully, but these errors were encountered: