-
Notifications
You must be signed in to change notification settings - Fork 325
Retain ipfs:// when localhost gateway is used #974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thank you for reporting this @markg85, this needs to be fixed in Brave (Companion does not control how address bar renders things). |
That is a better title indeed :) Thank you! But i don't get why it's a Brave thing. I mean, somehow it does know how to resolve the site |
@markg85 can you explain how to reproduce? Maybe a screenshot of your brave://settings/extensions please? Thanks! |
That is exactly the problem. Btw. It's awesome that Brave now natively supports IPFS. Thank you for that, @bbondy! |
As this is Brave-specific behavior independent from Companion, |
it'll retain the ipns:// URI with the issue that @lidel mentioned though, as long as the configured gateway is localhost and matching your setting. |
Hi,
I'm not quite sure if this is a bug or a feature. Or perhaps even well intentional but i don't understand it.
I'm running ipfs companion on the latest fancy brave (with IPFS):
Version 1.19.86 Chromium: 88.0.4324.96 (Official Build) unknown (64-bit)
Now any IPFS site i visit gets this appended to the URL:
ipns.localhost:8080
I'm fine with that if i'm using http:// or https:// and that clearly shows i'm using a gateway. A local one in this case.
In this very specific case i'm visiting (as in typing in the url bar):
ipns://dnslink.io
Which gets rewritten to:
http://dnslink.io.ipns.localhost:8080/
This makes no sense to me.
I'm specifically using the
ipfs
protocol so i'm expecting it not to be rewritten to the http protocol.Am i just missing a checkbox somewhere that would fix this?
Or is this a bug? Or an intentional feature?
Best regards,
Mark
The text was updated successfully, but these errors were encountered: