Skip to content

Replace graphics on RE onboarding (uplift to 1.20.x) #7768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Feb 2, 2021

Uplift of #7766
Resolves brave/brave-browser#13749

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team February 2, 2021 00:53
@brave-builds brave-builds self-assigned this Feb 2, 2021
@brave-builds brave-builds added this to the 1.20.x - Beta milestone Feb 2, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Feb 2, 2021

iOS failed due to build failing as per https://ci.brave.com/job/pr-brave-browser-pr7766_issue_13749_1.20.x-ios/1/execution/node/137/log/. However, this change is isolated to Android so there's no need to restart/pass iOS. Other platforms including iOS were also skipped via the 1.19.x uplift as per #7773.

21:07:29  [9324/19802] ACTION //brave/vendor/brave-ios:ads_mojo_gen_wrappers(//build/toolchain/mac:ios_clang_arm64)
21:07:29  FAILED: gen/brave/vendor/brave-ios/ads.mojom.objc.h gen/brave/vendor/brave-ios/ads.mojom.objc+private.h gen/brave/vendor/brave-ios/ads.mojom.objc.mm gen/brave/vendor/brave-ios/objc_templates_bytecode/ads_objc_templates.zip 

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.20.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #7766 (comment).

@kjozwiak kjozwiak merged commit f107e6c into 1.20.x Feb 2, 2021
@kjozwiak kjozwiak deleted the pr7766_issue_13749_1.20.x branch February 2, 2021 18:00
@deeppandya deeppandya changed the title Fix #13749 (uplift to 1.20.x) Replace graphics on RE onboarding (uplift to 1.20.x) Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants