Skip to content

Replace graphics on RE onboarding #13749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
srirambv opened this issue Jan 25, 2021 · 2 comments · Fixed by brave/brave-core#7766
Closed

Replace graphics on RE onboarding #13749

srirambv opened this issue Jan 25, 2021 · 2 comments · Fixed by brave/brave-core#7766
Labels
bug feature/rewards onboarding Front-end related to helping a new user learn about features within the browser. OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.19.x - Release #3

Comments

@srirambv
Copy link
Contributor

srirambv commented Jan 25, 2021 •
edited
Loading

Description

Replace graphics on RE onboarding

Steps to reproduce

  1. Clean install 1.20.85 x64 beta build
  2. Go through RE onboarding
  3. Graphics has some junk characters

Actual result

Garbled You Arrow not visible
image

Expected result

As per
image

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? No
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet):Phone
  • Android version: 10

Brave version

1.20.85 Beta Build

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @codybanxs
Follow up to #13055
@srirambv srirambv added bug feature/rewards QA/Yes release-notes/exclude onboarding Front-end related to helping a new user learn about features within the browser. OS/Android Fixes related to Android browser functionality labels Jan 25, 2021
@srirambv srirambv mentioned this issue Jan 25, 2021
Closed
This was referenced Feb 1, 2021
Closed
Merged
@brave-builds brave-builds mentioned this issue Feb 2, 2021
Merged
4 tasks
@kjozwiak kjozwiak added this to the 1.21.x - Nightly milestone Feb 2, 2021
@deeppandya deeppandya mentioned this issue Feb 2, 2021
Merged
4 tasks
@srirambv
Copy link
Contributor Author

srirambv commented Feb 3, 2021

Verification passed on OnePlus 6T with Android 10 running 1.19.90 x64 build

  • Verified the graphics on first and fifth screens are replaced according to the new spec
  • Verified other images on the welcome tour are not affected
image image

Verification passed on Samsung Tab A with Android 10 running 1.19.90 x64 build

  • Verified the graphics on first and fifth screens are replaced according to the new spec
  • Verified other images on the welcome tour are not affected
image image

@kjozwiak
Copy link
Member

kjozwiak commented Feb 4, 2021

Currently happening in 1.19.88 CR: 88.0.4324.96 so adding release-notes/include as the issue was already user facing.

This was referenced Feb 4, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug feature/rewards onboarding Front-end related to helping a new user learn about features within the browser. OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
None yet
Milestone
1.19.x - Release #3
Development

Successfully merging a pull request may close this issue.

Replace graphics on RE onboarding brave/brave-core
2 participants
@kjozwiak @srirambv