Update modal behaviour android #7761
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deeppandya
added
CI/skip-linux
CI/skip-macos-x64
| @@ -293,8 +293,10 @@ void JNI_BravePrefServiceBridge_SetReferralDownloadId( | |||
| void JNI_BravePrefServiceBridge_SetP3AEnabled( | |||
| JNIEnv* env, | |||
| jboolean value) { | |||
| return g_browser_process->local_state()->SetBoolean( | |||
| brave::kP3AEnabled, value); | |||
| // Saving pref value to the disk as soon as the pref value is set to avoid delay in pref value update. | |||
There was a problem hiding this comment.
it will not pass lint, over 80 chars
There was a problem hiding this comment.
yeah i just noticed. updating it.
|
Closing this PR as creating new separate PRS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#12627 brave/brave-browser#13800 brave/brave-browser#13871 brave/brave-browser#13749
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed).Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on.
Test Plan: