Skip to content

Enable p3a by default android (Uplift to 1.19.x) #7566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

deeppandya
Copy link
Contributor

Uplift of #7565
Resolves brave/brave-browser#13486

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jan 12, 2021
@deeppandya deeppandya added this to the 1.19.x - Beta milestone Jan 12, 2021
@deeppandya deeppandya requested a review from a team January 12, 2021 01:24
@deeppandya deeppandya self-assigned this Jan 12, 2021
@deeppandya
Copy link
Contributor Author

Added commit here : c261046 so closing this PR

@deeppandya deeppandya closed this Jan 13, 2021
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 13, 2021

Verification passed on Samsung Galaxy J3 version 5.1.1 running Bravearm 1.20.74.apk

Logged :
brave/brave-browser#13537
brave/brave-browser#13539
brave/brave-browser#13540
brave/brave-browser#13541

New user

  • Verified the initial welcome screen display with P3A checkbox after app launch
    image

  • Verified that for new users who viewed and clicked on the Continue button in the onboarding screen, the stats p3a.enabled and notice_acknowledged are returng true value in local-state file
    image

  • Verified that, click on the Private product analytics link redirects to https://brave.com/p3a

  • In a clean profile 1.20.74 after app launch, uncheck the P3A checkbox and open brave://local-state file and ensured that p3a.enabled is returning false and p3a.notice_acknowledged is equal to true
    image

Existing user

  • Verified that the P3A checkbox modal is shown for the existing users on the next app launch
    image
  • Verified the Graphics displayed on the P3A screen with Figma doc

@GeetaSarvadnya
Copy link

@AlexeyBarabash @deeppandya I have set Brave Nightly 1.20.74 as the default browser in Android, the chrome://local-state file is returning the value as 0 for the default browser stats Brave.Core.IsDefault. Looks like P3A stats are not returning correct values in Android. The same thing works fine in Desktop

image

@AlexeyBarabash
Copy link
Contributor

@GeetaSarvadnya
you are right, for now not all the metrics are supported in Android, #7016 (comment)

@GeetaSarvadnya
Copy link

@AlexeyBarabash Can you please specify which metrics are supported in Android right now? So that we can test in this milestone.

@AlexeyBarabash
Copy link
Contributor

@GeetaSarvadnya the metrics table is in message #7016 (comment) .

The supported are:

Brave.Core.BookmarksCountOnProfileLoad.2
Brave.Core.TabCount
Brave.P3A.SentAnswersCount
Brave.Rewards.AdsState.2
Brave.Rewards.AutoContributionsState.2
Brave.Rewards.TipsState.2
Brave.Rewards.WalletBalance.2
Brave.Savings.BandwidthSavingsMB
Brave.Search.DefaultEngine.2
Brave.P2A.TotalAdOpportunities
Brave.P2A.AdOpportunitiesPerSegment.*
Brave.P2A.TotalAdImpressions
Brave.P2A.AdImpressionsPerSegment.*

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 13, 2021

Verified the metrics mentioned in the #7566 (comment)

Brave.Core.BookmarksCountOnProfileLoad
  • Ensured that the response value for BookmarksCountOnProfileLoad=0 when there is no bookmarks in on profile load.
    image
  • Ensured that the response value for BookmarksCountOnProfileLoad=1 when the bookmarks count is in the range 0-5
    image
  • Ensured that the response value for BookmarksCountOnProfileLoad=2 when the bookmarks count is in the range 21-100
    image
Brave.Core.TabCount
  • Ensured that the response value for Brave.Core.TabCount=0 when tab count is in the range 0-1
    image
  • Ensured that the response value for Brave.Core.TabCount=1 when tab count is in the range 2-5
    image
Brave.P3A.SentAnswersCount
  • Ensured that the response value for Brave.P3A.SentAnswersCount=2 when SentAnswersCount is in the range 5-9
    image
Brave.Search.DefaultEngine.2
  • Ensured that the response value for Brave.Search.DefaultEngine=1 when Search.DefaultEngine is set to google
    image
  • Ensured that the response value for Brave.Search.DefaultEngine=2 when Search.DefaultEngine is set to duckduckgo
    image
  • Ensured that the response value for Brave.Search.DefaultEngine=4 when Search.DefaultEngine is set to bing
    image
  • Ensured that the response value for Brave.Search.DefaultEngine=7 when Search.DefaultEngine is set to Ecosia
    image
Brave.Rewards.AdsState
Brave.Rewards.AutoContributionsState
Brave.Rewards.TipsState

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants