Skip to content

P3A welcome screen content isn't translated in other locales #13541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GeetaSarvadnya opened this issue Jan 13, 2021 · 3 comments
Closed

P3A welcome screen content isn't translated in other locales #13541

GeetaSarvadnya opened this issue Jan 13, 2021 · 3 comments
Labels
bug closed/invalid l10n OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/Test-Plan-Specified QA/Yes

Comments

@GeetaSarvadnya
Copy link

Description

P3A welcome screen content isn't translated in other locales

Steps to reproduce

  1. Set the device languages to Deutsch (Germany)
  2. Install the brave app 1.20.74
  3. After the app launch, P3A welcome screen content isn't translated to Deutsch (Germany)
  4. P3A welcome screen content isn't translated in other locales

Actual result

P3A welcome screen content isn't translated in other locales
image

Expected result

P3A welcome screen content should be translated in other locales

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? NA
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Samsung Galaxy J3
  • Android version: 5.1.1

Brave version

1.20.74

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @brave/legacy_qa @SergeyZhukovsky @anthonypkeane

@GeetaSarvadnya GeetaSarvadnya added bug l10n QA/Yes QA/Test-Plan-Specified OS/Android Fixes related to Android browser functionality labels Jan 13, 2021
@GeetaSarvadnya GeetaSarvadnya added this to the 1.20.x - Nightly milestone Jan 13, 2021
@GeetaSarvadnya GeetaSarvadnya removed this from the 1.20.x - Nightly milestone Jan 13, 2021
@anthonypkeane anthonypkeane added the priority/P2 A bad problem. We might uplift this to the next planned release. label Apr 21, 2021
@anthonypkeane
Copy link

@GeetaSarvadnya can you please re-check this one and open if needed? Thanks

@anthonypkeane
Copy link

Tested and seems to no longer be an issue

@GeetaSarvadnya
Copy link
Author

The issue is fixed and working fine. P3A welcome screen is translated in Germany and other locales.

Verification passed on Samsung Galaxy J3 version 5.1.1 Bravearm 1.20.107.apk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug closed/invalid l10n OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA/Test-Plan-Specified QA/Yes
Projects
None yet
Development

No branches or pull requests

2 participants