Skip to content

Fixes do not log classified page url in locally persisted diagnostic log for Brave Ads #6139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 21, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jul 21, 2020

Resolves brave/brave-browser#10832

Submitter Checklist:

Test Plan:

Confirm tabUrl and visited page urls do not appear in the Brave Rewards diagnostic log

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmancey
Copy link
Collaborator Author

tmancey commented Jul 21, 2020

CI failed for known issue with rewards browser test

@tmancey tmancey merged commit 9dbc5f4 into master Jul 21, 2020
@tmancey tmancey deleted the issues/10832 branch July 21, 2020 19:45
@tmancey tmancey added this to the 1.13.x - Nightly milestone Jul 21, 2020
@pes10k
Copy link
Contributor

pes10k commented Jul 21, 2020

Thanks @tmancey for getting that sorted out so quickly!

@diracdeltas
Copy link
Member

@tmancey i forget, are we clearing this log every time user clears history? if not i think we need to do an update to clear these entries in the log (for existing logs).

@tmancey
Copy link
Collaborator Author

tmancey commented Jul 21, 2020

@diracdeltas We tail the log at 10mb to the last 20,000 lines so the log cycles quite quickly as the rewards log is quite verbose, and the log is deleted if rewards is disabled. Or the user can click "Clear log" on the brave://rewards-internals page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] Do not log classified page url in locally persisted diagnostic log for Brave Ads
5 participants