Skip to content

[Desktop] Do not log classified page url in locally persisted diagnostic log for Brave Ads #10832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tmancey opened this issue Jul 21, 2020 · 3 comments · Fixed by brave/brave-core#6139

Comments

@tmancey
Copy link
Contributor

tmancey commented Jul 21, 2020

Description

Do not log classified page url in locally persisted diagnostic log for Brave Ads

Steps to Reproduce

  1. Join rewards
  2. Navigate to a url

Actual result:

url is added to diagnostic log

Expected result:

url should not be added to diagnostic log

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? yes
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

@LaurenWags
Copy link
Member

Marking as QA/Blocked pending question sent to @tmancey

Want to confirm that the test plan only applies to logs going forward, not backward.

@tmancey
Copy link
Contributor Author

tmancey commented Aug 18, 2020

This PR only applies to logs going forward as there is another PR from @NejcZdovc which will remove/disable logging which will now remove all legacy logs

@LaurenWags
Copy link
Member

LaurenWags commented Aug 19, 2020

Verified passed with

Brave | 1.13.77 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
-- | --
Revision | 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS | macOS Version 10.14.6 (Build 18G3020)

Verification passed on

Brave | 1.13.77 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
-- | --
Revision | 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS | Windows 10 OS Version 1903 (Build 18362.1016)


Verification passed on

Brave 1.13.77 Chromium: 85.0.4183.69 (Official Build) dev (64-bit)
Revision 4554ea1a1171bd8d06951a4b7d9336afe6c59967-refs/branch-heads/4183@{#1426}
OS Ubuntu 18.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
4 participants