Skip to content

Exceptions for Uphold (netverify and veriff.me) #4039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 22, 2019
Merged

Exceptions for Uphold (netverify and veriff.me) #4039

merged 3 commits into from
Nov 22, 2019

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Nov 20, 2019 •
edited
Loading

Uplift of #4012
Uplift of #3425
Uplift of #3381

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@jumde jumde requested a review from a team November 20, 2019 17:14
@jumde jumde self-assigned this Nov 20, 2019
kjozwiak
kjozwiak approved these changes Nov 22, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.0.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any errors. Please make sure that all the correct labels are used and the associated issue(s) are moved into the correct milestone.

@jumde jumde merged commit cd7c59a into 1.0.x Nov 22, 2019
@jumde jumde deleted the uphold_exceptions_1.0.x branch November 22, 2019 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@jumde jumde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jumde @kjozwiak