Skip to content

Fix 6983: Add fingerprinting exception for veriff.me on uphold (uplift to 1.2.x) #4028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 22, 2019
Merged

Fix 6983: Add fingerprinting exception for veriff.me on uphold (uplift to 1.2.x) #4028

merged 1 commit into from
Nov 22, 2019

Conversation

brave-builds
Copy link
Collaborator

Uplift of #4012

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds self-assigned this Nov 19, 2019
@brave-builds brave-builds added this to the 1.2.x - Dev milestone Nov 19, 2019
@jumde jumde force-pushed the pr4012_uphold_veriff_1.2.x branch from 7b4b51e to 0709cd6 Compare November 21, 2019 15:19
kjozwiak
kjozwiak approved these changes Nov 22, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.2.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without any errors. Please make sure that all the correct labels are used and the associated issue(s) are moved into the correct milestone.

@jumde jumde merged commit 9df0221 into 1.2.x Nov 22, 2019
@jumde jumde deleted the pr4012_uphold_veriff_1.2.x branch November 22, 2019 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

@bbondy bbondy Awaiting requested review from bbondy

@bsclifton bsclifton Awaiting requested review from bsclifton

@rebron rebron Awaiting requested review from rebron

@srirambv srirambv Awaiting requested review from srirambv

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.2.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @jumde @brave-browser-releases