Skip to content

Updating welcome page text for anon wallets (0.71) #3934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2019
Merged

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Nov 8, 2019

Updating welcome page text for anon wallets
@ryanml ryanml added this to the 0.71.x - Release milestone Nov 8, 2019
@ryanml ryanml requested a review from a team November 8, 2019 17:16
@ryanml ryanml requested a review from NejcZdovc as a code owner November 8, 2019 17:16
@ryanml ryanml self-assigned this Nov 8, 2019
@kjozwiak
Copy link
Member

kjozwiak commented Nov 8, 2019

Restarting Linux due to the following failure as per https://ci.brave.com/job/brave-browser-build-pr/job/uplift-3897-71/1/execution/node/362/log/:

14:30:22  [24715:24749:1108/193022.163630:ERROR:bus.cc(393)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
14:30:22  [24715:24749:1108/193022.163657:ERROR:bus.cc(393)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
14:30:22  [24715:24725:1108/193022.214018:ERROR:rewards_service_impl.cc(198)] Failed to read file: /home/ubuntu/.config/BraveSoftware/brave-network-test/Default/ledger_state
14:30:22  [24761:24761:1108/193022.217910:ERROR:ledger_impl.cc(102)] Failed to initialize wallet
14:31:30  [24715:24715:1108/193122.153066:ERROR:gcm_channel_status_request.cc(145)] GCM channel request failed.
14:31:48  [24715:24715:1108/193144.922820:ERROR:gcm_channel_status_request.cc(145)] GCM channel request failed.
14:32:20  undefined:18091
14:32:20  {"phase":0,"source":{"id":129,"type":9}]}
14:32:20                                         ^
14:32:20  
14:32:20  SyntaxError: Unexpected token ] in JSON at position 78947261
14:32:20      at JSON.parse (<anonymous>)
14:32:20      at start (/home/ubuntu/jenkins/workspace/_browser-build-pr_uplift-3897-71/lib/start.js:144:23)
14:32:20      at Command.listener (/home/ubuntu/jenkins/workspace/_browser-build-pr_uplift-3897-71/node_modules/commander/index.js:315:8)
14:32:20      at Command.emit (events.js:210:5)
14:32:20      at Command.parseArgs (/home/ubuntu/jenkins/workspace/_browser-build-pr_uplift-3897-71/node_modules/commander/index.js:654:12)
14:32:20      at Command.parse (/home/ubuntu/jenkins/workspace/_browser-build-pr_uplift-3897-71/node_modules/commander/index.js:474:21)
14:32:20      at Object.<anonymous> (/home/ubuntu/jenkins/workspace/_browser-build-pr_uplift-3897-71/scripts/commands.js:156:4)
14:32:20      at Module._compile (internal/modules/cjs/loader.js:956:30)
14:32:20      at Object.Module._extensions..js (internal/modules/cjs/loader.js:973:10)
14:32:20      at Module.load (internal/modules/cjs/loader.js:812:32)
14:32:20  npm ERR! code ELIFECYCLE

Restarting Win x64 due to the following failure as per https://ci.brave.com/job/brave-browser-build-pr/job/uplift-3897-71/1/execution/node/241/log/:

14:27:45  Cannot contact i-0fe987222006cf1b4: hudson.remoting.RequestAbortedException: java.io.IOException: Unexpected termination of the channel
14:32:49  Could not connect to i-0fe987222006cf1b4 to send interrupt signal to process

@kjozwiak kjozwiak added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Nov 8, 2019
@rebron rebron removed the request for review from NejcZdovc November 9, 2019 01:03
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.71.x approved after deliberating with @brave/uplift-approvers. Both CI/Jenkins and CI/Travis passed without failures. Please make sure that the correct labels are added and the associated issue is moved into the correct milestone.

@kjozwiak kjozwiak merged commit beedc0f into 0.71.x Nov 9, 2019
@kjozwiak kjozwiak deleted the uplift-3897-71 branch November 9, 2019 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants