Skip to content

BAT Points text needed on BR slide of desktop onboarding flow #6602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mattmcalister opened this issue Oct 24, 2019 · 3 comments · Fixed by brave/brave-core#3897
Closed

BAT Points text needed on BR slide of desktop onboarding flow #6602

mattmcalister opened this issue Oct 24, 2019 · 3 comments · Fixed by brave/brave-core#3897
Assignees
@ryanml
Labels
bug feature/rewards l10n QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
1.0.0 - Release

Comments

@mattmcalister
Copy link

Small copy change on the final BR screen of onboarding. Use revised copy for Japan:

Change -> "Get paid to view relevant ads that respect your privacy"

To -> "Collect points when you view relevant ads that respect your privacy"
Screen Shot 2019-10-24 at 11 31 24
@NejcZdovc NejcZdovc added this to the 0.71.x - Beta milestone Oct 24, 2019
@rebron rebron added 1.0-suggestion closed/duplicate Issue has already been reported and removed 1.0 labels Oct 29, 2019
@rebron
Copy link
Collaborator

rebron commented Oct 30, 2019

Closing. Duplicate of #6654

@rebron rebron closed this as completed Oct 30, 2019
@kjozwiak kjozwiak removed the closed/duplicate Issue has already been reported label Oct 31, 2019
@kjozwiak kjozwiak reopened this Oct 31, 2019
@kjozwiak kjozwiak added the 1.0 label Oct 31, 2019
@kjozwiak
Copy link
Member

Going to re-open this one as #6654 will address changing BAT -> BAP and tokens -> points. This particular issue addresses a small change within the onboarding text of brave://rewards.

@kjozwiak kjozwiak mentioned this issue Oct 31, 2019
Merged
32 tasks
@rebron rebron added the l10n label Nov 1, 2019
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Nov 4, 2019
Closed
@ryanml ryanml mentioned this issue Nov 6, 2019
Merged
32 tasks
This was referenced Nov 8, 2019
Merged
Merged
@ryanml ryanml mentioned this issue Nov 8, 2019
Merged
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 11, 2019 •
edited by kjozwiak
Loading

Verification passed on

Brave 0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verification passed on

Brave 0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Ubuntu 18.04 LTS

image

Verification PASSED on macOS 10.15.1 x64 using the following build:

Brave 0.71.114 Chromium: 78.0.3904.97 (Official Build) (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.15.1 (Build 19B88)

Screen Shot 2019-11-11 at 10 50 20 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanml ryanml

Labels
bug feature/rewards l10n QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.0.0 - Release
Development

Successfully merging a pull request may close this issue.

Updating welcome page text for anon wallets brave/brave-core
8 participants
@mattmcalister @kjozwiak @rebron @ryanml @NejcZdovc @LaurenWags @btlechowski @GeetaSarvadnya