Skip to content

Build fix on MacOS release build #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2018
Merged

Build fix on MacOS release build #327

merged 1 commit into from
Aug 14, 2018

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Aug 14, 2018 •
edited
Loading

Close brave/brave-browser#750

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions

@simonhong simonhong self-assigned this Aug 14, 2018
@simonhong simonhong requested a review from bbondy August 14, 2018 03:28
bbondy
bbondy approved these changes Aug 14, 2018
View reviewed changes
Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doh thanks, maybe we can get channels without chrome/common/channel_info.h in the future at all. This is fine for now.

@bbondy bbondy merged commit 6127e33 into master Aug 14, 2018
@simonhong simonhong deleted the mac_build_fix branch August 19, 2018 23:22
srirambv pushed a commit to srirambv/brave-core that referenced this pull request Aug 20, 2018
@pes10k
removed referrer exception rule for moremorewin.net, which seems to b…
bae1920 
…e dead and down (closes brave#327)
petemill pushed a commit to petemill/brave-core that referenced this pull request Jul 5, 2019
@ryanml
Imported from brave-ui: Merge pull request brave#327 from ryanml/fix-…
1042287 
…2668

Allows for custom publisher logo in donationOverlay
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbondy bbondy bbondy approved these changes

Assignees

@simonhong simonhong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonhong @bbondy