Skip to content

Release build fail on MacOS #750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
simonhong opened this issue Aug 14, 2018 · 0 comments
Closed

Release build fail on MacOS #750

simonhong opened this issue Aug 14, 2018 · 0 comments
Assignees
Labels

Comments

@simonhong
Copy link
Member

simon-home:brave-browser-new simonhong$ yarn build Release
yarn run v1.5.1
$ node ./scripts/commands.js build Release
touch original files overridden by chromium_src...
/Users/simonhong/Projects/brave/brave-browser-new/src/base/mac/foundation_util.mm is touched.
update branding...
building brave...
gn gen /Users/simonhong/Projects/brave/brave-browser-new/src/out/Release --args="safe_browsing_mode=1 use_egl=false root_extra_deps=[\"//brave\"] is_component_build=false proprietary_codecs=true ffmpeg_branding=\"Chrome\" enable_nacl=false enable_widevine=true target_cpu=\"x64\" is_official_build=true is_debug=false dcheck_always_on=false brave_channel=\"\" google_api_key=\"AIzaSyAH90V94EcZBP5oH7oc-mXQrSKgASVxER8\" brave_google_api_key=\"AIzaSyAQfxPJiounkhOjODEO5ZieffeBv6yft2Q\" brave_google_api_endpoint=\"https://www.googleapis.com/geolocation/v1/geolocate?key=\" brave_product_name=\"Brave\" brave_project_name=\"brave\" brave_version_major=\"0\" brave_version_minor=\"54\" brave_version_build=\"0\" chrome_version_string=\"69.0.3497.32\" safebrowsing_api_endpoint=\"safebrowsing.brave.com\" mac_signing_identifier=\"\" mac_signing_keychain=\"login\" cc_wrapper=\"/Users/simonhong/Projects/brave/brave-browser-new/src/brave/script/redirect-cc.py\" "
Done. Made 9180 targets from 1668 files in 5901ms
ninja -C /Users/simonhong/Projects/brave/brave-browser-new/src/out/Release brave
ninja: Entering directory `/Users/simonhong/Projects/brave/brave-browser-new/src/out/Release'
[1/1] Regenerating ninja files
[26/1641] OBJCXX obj/base/base/foundation_util.o
FAILED: obj/base/base/foundation_util.o
/Users/simonhong/Projects/brave/brave-browser-new/src/brave/script/redirect-cc.py ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/base/base/foundation_util.o.d -DSYSTEM_NATIVE_UTF8 -DBRAVE_CHROMIUM_BUILD -DV8_DEPRECATION_WARNINGS -DNO_TCMALLOC -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DOFFICIAL_BUILD -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -D_LIBCPP_HAS_NO_ALIGNED_ALLOCATION -DCR_XCODE_VERSION=0941 -DCR_CLANG_REVISION=\"337439-1\" -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DBASE_IMPLEMENTATION -I../../brave/chromium_src -I. -I../.. -Igen -fno-strict-aliasing -fstack-protector -fcolor-diagnostics -fmerge-all-constants -Xclang -mllvm -Xclang -instcombine-lower-dbg-declare=0 -no-canonical-prefixes -arch x86_64 -Wall -Werror -Wextra -Wimplicit-fallthrough -Wthread-safety -Wunguarded-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-unneeded-internal-declaration -Wno-undefined-var-template -Wno-address-of-packed-member -Wno-nonportable-include-path -Wno-user-defined-warnings -Wno-unused-lambda-capture -Wno-null-pointer-arithmetic -Wno-enum-compare-switch -Wno-ignored-pragma-optimize -fno-omit-frame-pointer -gdwarf-2 -fno-standalone-debug -isysroot ../../../../../../../../Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.13.sdk -mmacosx-version-min=10.9.0 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang enforce-in-thirdparty-webkit -Xclang -plugin-arg-find-bad-constructs -Xclang check-enum-max-value -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wno-char-subscripts -Wglobal-constructors -Wexit-time-destructors -Wexit-time-destructors -Wshadow -Wexit-time-destructors -O2 -std=c++14 -stdlib=libc++ -fobjc-call-cxx-cdtors -Wobjc-missing-property-synthesis -fno-exceptions -fno-rtti -fvisibility-inlines-hidden -c ../../base/mac/foundation_util.mm -o obj/base/base/foundation_util.o
/Users/simonhong/Projects/brave/brave-browser-new/src/brave/chromium_src/base/mac/foundation_util.mm:22:11: error: use of undeclared identifier 'chrome'
  switch (chrome::GetChannel()) {
          ^
1 error generated.
[29/994] ACTION //brave/vendor/brave-extension:brave-extension(//build/toolchain/mac:clang_x64)
ninja: build stopped: subcommand failed.
null
null
error An unexpected error occurred: "Command failed.
Exit code: 1
Command: sh
Arguments: -c node ./scripts/commands.js build Release
Directory: /Users/simonhong/Projects/brave/brave-browser-new
Output:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants