Skip to content

Fixes 503 response does not add confirmation to queue #3126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2019
Merged

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Aug 8, 2019

Fixes brave/brave-browser#5599

Submitter Checklist:

Test Plan:

  • Confirm creation of confirmations retry if response fails

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaurenWags
Copy link
Member

Brave 0.71.44 Chromium: 76.0.3809.132 (Official Build) nightly (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X

Using the above version, I utilized Charles Proxy to emulate a 503 response to createConfirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix 503 response not adding confirmation to queue to be retried
3 participants