-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Brave Ads target URLs that redirect to a different hostname are not sustained #4026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
bug
closed/duplicate
Issue has already been reported
feature/ads
priority/P3
The next thing for us to work on. It'll ride the trains.
QA/Yes
release-notes/include
Comments
question: is this the same problem when trying to see wishlist from aliexpress? either disabling shields for this site or entering private mode, the navigation does not pass login verification. Shopping card works. |
Reproduced with
|
32 tasks
When this is fixed, we should check #5195 works for redirects. |
Closing issue as will be resolved by #11012 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
closed/duplicate
Issue has already been reported
feature/ads
priority/P3
The next thing for us to work on. It'll ride the trains.
QA/Yes
release-notes/include
Description
Ad Target URLs that redirect to a different hostname are not sustained.
Steps to Reproduce
Actual result:
Ad fails to confirm that it landed
Expected result:
Ad should confirm that it has landed
Reproduces how often:
Easily reproduced
Brave version (brave://version info)
Brave | 0.63.31 Chromium: 73.0.3683.75 (Official Build) beta(64-bit)
Revision | 909ee014fcea6828f9a610e6716145bc0b3ebf4a-refs/branch-heads/3683@{#803}
OS | Mac OS X
Reproducible on current release:
Website problems only:
Additional Information
See
Default/rewards_service/confirmations.json
in the user profile directory andchrome-debug.log
in the user profile directory for logs.This is a known limitation, which also exists in Muon. A solution is to store the
uuid
(aka creative instance id) for the shown Ad as metadata for a tab and match the uuid instead of the hostname. This solution would also work for #3570 (Clicking on Ad landing page gets them included in to a-c)The text was updated successfully, but these errors were encountered: